<html>
<head><meta charset="utf-8"><title>red-green relevant impls · t-compiler/wg-incr-comp · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/index.html">t-compiler/wg-incr-comp</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/red-green.20relevant.20impls.html">red-green relevant impls</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="219910440"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/red-green%20relevant%20impls/near/219910440" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/red-green.20relevant.20impls.html#219910440">(Dec 14 2020 at 22:18)</a>:</h4>
<p>the following comment was added about incremental compilation 3 years ago <a href="https://github.com/rust-lang/rust/blob/fa416394275d2468d104b8f72ac31b1ddf7ee52e/compiler/rustc_middle/src/ty/trait_def.rs#L172">https://github.com/rust-lang/rust/blob/fa416394275d2468d104b8f72ac31b1ddf7ee52e/compiler/rustc_middle/src/ty/trait_def.rs#L172</a></p>
<p>is that still relevant or should we just remove it?</p>



<a name="219910694"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/red-green%20relevant%20impls/near/219910694" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/red-green.20relevant.20impls.html#219910694">(Dec 14 2020 at 22:20)</a>:</h4>
<blockquote>
<p>When we get red-green recompilation ...</p>
</blockquote>
<p>That sounds really out of date to me. AFAIK the red-green system is what we've had for a while now.</p>



<a name="219910907"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/red-green%20relevant%20impls/near/219910907" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/red-green.20relevant.20impls.html#219910907">(Dec 14 2020 at 22:22)</a>:</h4>
<p>yeah, the interesting part to me was</p>
<blockquote>
<p>// If we want to be faster, we could have separate queries for<br>
 // blanket and non-blanket impls, and compare them separately.</p>
</blockquote>



<a name="219958277"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241847-t-compiler/wg-incr-comp/topic/red-green%20relevant%20impls/near/219958277" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/241847-t-compiler/wg-incr-comp/topic/red-green.20relevant.20impls.html#219958277">(Dec 15 2020 at 10:12)</a>:</h4>
<p>Yeah, it's probably safe to remove the part of the comment add in <a href="https://github.com/rust-lang/rust/commit/453ad8122c975dc82f6090f0c755d38932ccefc5">453ad8122c975dc82f6090f0c755d38932ccefc5</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>